search

phalt / swapi

*NOT MAINTAINED - NO GUARENTEE TO BE UP*
https://phalt.github.io/pokeapi-and-swapi-going-forward/
BSD 3-Clause "New" or "Revised" License
891 stars 504 forks source link

Person: key species: String instead of [String] #67

Open AndreaMiotto opened 8 years ago

AndreaMiotto commented 8 years ago

Hi @phalt . Awesome job with this API, but I don't understand your choice for species' key in the person type. Why is it an array of String?? I've checked all the person records, and all the records have just one specie. And it's quite normale, I mean a person should have just one specie, how is it possibile to belong to two species?

So the specie's key shouldn't be just a single String like for planets?

I'm telling you because to fetch the species' name for the people it costs one more function than the planets name fetching.

Regards, Andrea Miotto

phalt commented 8 years ago

What if a character does have more than one species? 😉

AndreaMiotto commented 8 years ago

How can it be possible? 😁

phalt commented 8 years ago

It's a science fiction show!

nrapopor commented 7 years ago

Darth Vader is actually half man/half machine ... it's a data problem not a type problem ...