phamfoo / react-native-figma-squircle

Figma-flavored squircles for React Native
MIT License
318 stars 15 forks source link

feature: Added linear gradient background #7

Closed dev-andremonteiro closed 2 years ago

dev-andremonteiro commented 2 years ago

Made a fork with a new feature: Linear Gradient backgrounds!

I hope you guys like it, I tried to structure parameters as close to react-native-linear-gradient library so users are used to it.

phamfoo commented 2 years ago

Hey, thanks for the PR and sorry for the late review. I think it's reasonable to add linear gradient support this way, but I don't want to support every use case by introducing new props. Also, the library itself has some limitations and is not very flexible. In many cases, you're better off using figma-squircle to get the SVG path and implement your own SquircleView (as you did in this PR). I'm planning to convert this package to a native module sometime in the future, so I'm closing this.