search

phamos-eu / HR-Addon

HR Add-on for ERPNext
Other
24 stars 40 forks source link

update validation message on bulk workday creation #113

Closed sonalimandarnarkar closed 3 weeks ago

sonalimandarnarkar commented 3 weeks ago

#23 HR Addon Workdays

https://chat.phamos.eu/phamos/pl/sjghw9u9mjd9ic565gh5dtojyh

  1. The confirmation dialog message has been updated to display dates in a bullet list. Previously, the 'NO' button in frappe.confirm was not functioning correctly; clicking 'NO' still created workdays. This issue has been corrected, and the 'NO' button in frappe.confirm is now working as expected.
Screenshot 2024-09-06 at 17 40 04
  1. If workdays are already created for the provided date range, the confirmation dialog now displays a list of these workdays dates in a bullet list.
Screenshot 2024-09-06 at 17 40 20
sonalimandarnarkar commented 3 weeks ago

Please remember not to include the formatting changes in the PR, since it is difficult to review. Thanks. Make sure to use the vs code git functionality to check the changes before creating the PR. Apart from this, it looks nice 👍

I disabled pretty printer , but It was already sorted line before disabling , but I did seperate commit for it, I will do PR for next work. :) sorry