hoanle
commented
8 years ago @phamquangsang :+1: Great work. A few notes after checking out the code:
- Good to see you were able to format the timestamp cleanly
- Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
- Good to see you refreshed the timeline after composing a new tweet
- Nice touch with the character count being displayed while the user composes a tweet
- Glad to see you made the compose activity into a dialog instead
- Consider adding local persistence of tweets by using ActiveAndroid in the Tweet and User. See the persistence guide and this other guide for more details.
- It's not required, but using Butterknife can help u reduce extra code a lot
- You should organise the project
- It seems that you use setCompoundDrawablesWithIntrinsicBounds to change the image after user like a tweet. There is a simpler way to do it: using selector for drawable
- The functions: insertToDatabase, queryTweets should be put into a separate class, but not Utils class (Repository pattern)
- I saw user detail page but Why not implement a Tweet detail page?
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
My week 3 project is done. Please review. @coderschoolreview @lehoan