RottenTomatoes assignment - Completed

[phamthienbao]

Hello /cc @chug2k,

I've completed for required feature of this assignment. Pls help me to review it.

In addition, I'm researching for optional feature as well as improving the existing features.

Thanks, BaoP

[chug2k]

I had problems opening your project - are you sure you committed to GitHub correctly? I do not see a Podfile or an .xcworkspace.

[chug2k]

All of your code is blank - please make sure you upload the latest version of your code. If you come before class today I can work with you to see what went wrong with Git.

[phamthienbao]

Hello @chug2k ,

I've checked and re-upload the assigmen again. I dont know why all code are set as blank. Maybe, it's some problem with Source Contrl on Xcode 7.

Sorry for any unconvinced.

Thanks, Bao

[chug2k]

Much better. :bird:

I didn't mention this in class, but please be sure to follow the Swift code styling conventions for the homework. Here are a few useful guides:

• Ray Wenderlich Swift Style Guide
• Github Swift Style Guide

You are a little bit sloppy with your brackets and indentation. Please make sure your code is always correctly indented. Also please avoid variable names like movies_cells and index_path - it should be moviesCells and indexPath.

In class I only used a NSDictionary, but it would have been nice if you implemented a model class. The SwiftyJSON library is useful for this - https://github.com/SwiftyJSON/SwiftyJSON.

• Nice work with the custom Movie cell.
• Nice work loading the images asynchronously.
• Nice work implementing the error message on network failure. Next time consider using UIView.animateWithDuration to fade or slide the message instead of just hidden = false.
• You should also show "Network Error" for the Movie Details screen, when you try to load the high resolution image and there is no network.

I hope to see you complete more optional tasks this week!