search

phanan / vue-facebook-signin-button

A simple plugin to include a custom Facebook sign-in button into your web app.
137 stars 30 forks source link

Accessibility #3

Closed willtpwise closed 5 years ago

willtpwise commented 6 years ago

The output should be a <button> element, instead of a <div>.

Current

<div class="fb-signin-button">
    Sign in with Facebook
</div>

Proposed

<button role="button" class="fb-signin-button">
    Sign in with Facebook
</button>
adi518 commented 5 years ago

You don't need to pass an explicit role attribute. HTML button has that by default. You do need it in the case of unsemantic tags like a div, but the whole idea of this PR is to use a button, dismissing that completely. Shameless plug: I don't think this is an actively maintained project, so I created a more advanced component with better encapsulation and full control over HTML and CSS implementation.

fdorantesm commented 5 years ago

I solved wrapping the fake button into a real button but is necessary trigger the click event to the non button element... is not the best way.

I recently added this feature (i did'nt see your PR) and a click event emiter too.