search

phandasm / waveform

Audio spectral analysis plugin for OBS
https://obsproject.com/forum/resources/waveform.1423/
GNU General Public License v3.0
525 stars 37 forks source link

Option to remove sound floor graph line entirely #15

Closed JonasBjordal closed 2 years ago

JonasBjordal commented 2 years ago

I like the toggle option to hide the graph when the audio is silent, but if it removed the floor line entirely it'd be looking a lot better in my opinion. The line sticks out quite a bit when the visualizer has an exposed line for the sound floor or when using the stereo channel spacing feature recently added, in which the second channel will have no line at all (which looks a lot nicer).

Basically what I'm asking for is an update where neither channel has the horizontal sound floor line when the "hide graph when silent" toggle is selected for the curve and bar display modes,

phandasm commented 2 years ago

Do you mean when the audio is not truly silent but everything is below the floor threshold? Or do you just mean when any part of the graph drops to floor level?

If it's the latter that's kind of a problem because the curve graph renders as a big sheet of polygons that share vertices, cutting out parts isn't an option. For the bar renderer we could skip bars, maybe for the curve renderer we could do something with the pixel shader and hide it with alpha?

JonasBjordal commented 2 years ago

I mean the latter, and hiding the line that's showing the sound floor would probably be a perfect solution, yeah! I just thought it had a simple solution at first as the second stereo channel doesn't have the line at all if it's separated from the other when using the curve mode

phandasm commented 2 years ago

So this seems to have been somewhat incidentally solved as I was cleaning up the rendering code. In my testing I no longer see the floor line but I also didn't see it in most cases to begin with so I'm not 100% sure it's gone. If you still see it let me know and I'll reopen the issue.