search

phandasm / waveform

Audio spectral analysis plugin for OBS
https://obsproject.com/forum/resources/waveform.1423/
GNU General Public License v3.0
525 stars 37 forks source link

Plugin Crashes with OBS 29.1.3 #59

Closed 3345meggs closed 8 months ago

3345meggs commented 1 year ago

By adding the plugin in a scene in OBS and config an audio Source, OBS crashes.

phandasm commented 1 year ago

What platform? Seems to work fine with OBS 29.1.3 on windows. Crash log would be helpful.

3345meggs commented 1 year ago

Hi, sorry it was too late :) Platform Windows 11. Crash log attached. Crash 2023-11-12 14-13-18.txt

Edit: I use a VBAN Plugin as Audio Source, perhaps this could be the problem? By directly choose Mix/Aux OBS don't crashes. I have tested Audio Source direct from a video, OBS also crashes.

phandasm commented 1 year ago

Huh, that seems like a channel mapping or audio format issue but I can't reproduce it. Are you using waveform 1.7?

3345meggs commented 1 year ago

Yes, latest version

3345meggs commented 1 year ago

What Audio Format or Source is default for Waveform? We have tested something and have choosen Output Bus, OBS don't crash but we don't see anything from the plugin.

phandasm commented 1 year ago

Internally waveform expects planar float audio. Usually OBS handles the conversion so it shouldn't matter what the source is using, but issues can arise from ABI incompatibilities with forks of OBS (e.g. Music Edition) or misbehaving plugins (VLC's bogus timestamps).

I did actually test the VBAN plugin and it seemed to work just fine, but I had it mapped to standard stereo so maybe it depends on what channels are in use.

The audio callback unfortunately doesn't give much info on the provided audio beyond frame count.

We have tested something and have choosen Output Bus, OBS don't crash but we don't see anything from the plugin.

If your channel mapping is nonstandard, try setting Channel Mode to Single and cycle through channels until you see something.

3345meggs commented 8 months ago

Hi, after a while today i tried again and it works. I have updated to OBS 30.0.2 and to latest Waveform plugin.