Why do we need vocabulary_counts in skipgram.py?

phanein / deepwalk

DeepWalk - Deep Learning for Graphs

http://www.perozzi.net/projects/deepwalk/

Other

2.68k stars 826 forks source link

Why do we need vocabulary_counts in skipgram.py? #111

Open phucdoitoan opened 4 years ago

phucdoitoan commented 4 years ago

Hi, I try to figure out the role of vocabulary_counts in skipgram.py, but it seems that the variable self.vocabulary_counts does not have any effect on the codes. In the Word2Vec implementation https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/word2vec.py there is no use for vocabulary_counts neither.

Is it just a variable of an older version that is not necessary now?

GTmac commented 4 years ago

Yeah you are right! The skipgram.py implementation is based on a rather old version of Gensim word2vec; it is not necessary anymore. Would you like to clean this up? Happy to help with reviewing this. Thank you!