phanrahan / magma

magma circuits
Other
253 stars 24 forks source link

[When] Add support for unflattened tuples #1324

Closed rsetaluri closed 1 year ago

rsetaluri commented 1 year ago

Allows compiling when blocks to MLIR with flatten_all_tuples=False.

rsetaluri commented 1 year ago

@leonardt this is basically #1267 rebased on #1322.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 97.29% and project coverage change: -0.03% :warning:

Comparison is base (4475c36) 86.12% compared to head (726e71e) 86.09%.

:exclamation: Current head 726e71e differs from pull request most recent head 7c86be9. Consider uploading reports for the commit 7c86be9 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1324 +/- ## ========================================== - Coverage 86.12% 86.09% -0.03% ========================================== Files 171 171 Lines 17869 17897 +28 ========================================== + Hits 15389 15409 +20 - Misses 2480 2488 +8 ``` | [Files Changed](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [magma/backend/mlir/translation\_unit.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL3RyYW5zbGF0aW9uX3VuaXQucHk=) | `92.70% <50.00%> (-0.64%)` | :arrow_down: | | [magma/backend/mlir/hw.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL2h3LnB5) | `98.56% <83.33%> (-0.46%)` | :arrow_down: | | [magma/backend/mlir/compile\_to\_mlir\_opts.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL2NvbXBpbGVfdG9fbWxpcl9vcHRzLnB5) | `100.00% <100.00%> (ø)` | | | [magma/backend/mlir/hardware\_module.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL2hhcmR3YXJlX21vZHVsZS5weQ==) | `96.84% <100.00%> (+0.01%)` | :arrow_up: | | [magma/backend/mlir/magma\_ops.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL21hZ21hX29wcy5weQ==) | `100.00% <100.00%> (ø)` | | | [magma/backend/mlir/mlir\_compiler.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL21saXJfY29tcGlsZXIucHk=) | `95.45% <100.00%> (ø)` | | | [magma/backend/mlir/when\_utils.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL3doZW5fdXRpbHMucHk=) | `99.41% <100.00%> (+0.05%)` | :arrow_up: | | [magma/backend/mlir/xmr\_utils.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL3htcl91dGlscy5weQ==) | `91.93% <100.00%> (+0.13%)` | :arrow_up: | | [magma/inline\_verilog.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvaW5saW5lX3Zlcmlsb2cucHk=) | `98.11% <100.00%> (+0.89%)` | :arrow_up: | | [magma/passes/when.py](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvcGFzc2VzL3doZW4ucHk=) | `100.00% <100.00%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/phanrahan/magma/pull/1324?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/phanrahan/magma/pull/1324/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.