Extend set_index for N-D Arrays

rkshthrmsh commented 1 year ago

Add suppport for N-dimensional indices.
Add more information to assertion messages.

rkshthrmsh commented 1 year ago

@rsetaluri, I have committed all the suggestions. Thanks!

rkshthrmsh commented 1 year ago

@rsetaluri, I have made the necessary changes to the test file. However, I'm unable to run it because pip install fault fails with:

 ERROR: Failed building wheel for coreir
  Building wheel for DeCiDa (pyproject.toml) ... done
  Created wheel for DeCiDa: filename=DeCiDa-1.1.5-py3-none-any.whl size=13947008 sha256=8dda2758409edef16994bd393ab64c3e7f6e25e80a597367ac0f1fb4a18f0595
  Stored in directory: /Users/rkshthrmsh/Library/Caches/pip/wheels/64/21/c3/f58e97f65bdac62c9ac1e98711dc44d30300e8801a4eccc2f8
Successfully built fault DeCiDa
Failed to build coreir
ERROR: Could not build wheels for coreir, which is required to install pyproject.toml-based projects

How can I get around this?

EDIT: Noticed a deprecate_coreir branch in fault. Built from source using that branch as per #1281.

rkshthrmsh commented 1 year ago

@rsetaluri, added test for N-D set_index()

rkshthrmsh commented 10 months ago

@rsetaluri / @leonardt, any update on this PR?

leonardt commented 10 months ago

@rkshthrmsh can you either merge or rebase on the latest master just to make sure it's working with the latest head?

rkshthrmsh commented 8 months ago

Closing this as it is merged in #1353

phanrahan / magma

Extend set_index for N-D Arrays #1330