codecov-commenter
commented
1 year ago Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.
Comparison is base (
e0a49bb) 86.09% compared to head (1a65e64) 86.07%. Report is 7 commits behind head on master.:exclamation: Current head 1a65e64 differs from pull request most recent head 4f7ca3a. Consider uploading reports for the commit 4f7ca3a to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1333 +/- ## ========================================== - Coverage 86.09% 86.07% -0.03% ========================================== Files 171 171 Lines 17897 17917 +20 ========================================== + Hits 15409 15422 +13 - Misses 2488 2495 +7 ``` | [Files](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [magma/backend/mlir/hardware\_module.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL2hhcmR3YXJlX21vZHVsZS5weQ==) | `96.84% <100.00%> (+<0.01%)` | :arrow_up: | | [magma/backend/mlir/when\_utils.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYmFja2VuZC9tbGlyL3doZW5fdXRpbHMucHk=) | `99.43% <100.00%> (+0.01%)` | :arrow_up: | | [magma/circuit.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvY2lyY3VpdC5weQ==) | `92.64% <100.00%> (+0.01%)` | :arrow_up: | | [magma/generator.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvZ2VuZXJhdG9yLnB5) | `95.37% <100.00%> (+0.08%)` | :arrow_up: | | [magma/inline\_verilog.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvaW5saW5lX3Zlcmlsb2cucHk=) | `98.14% <100.00%> (+0.03%)` | :arrow_up: | | [magma/value\_utils.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvdmFsdWVfdXRpbHMucHk=) | `97.72% <100.00%> (+0.05%)` | :arrow_up: | | [magma/bitutils.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvYml0dXRpbHMucHk=) | `90.90% <66.66%> (-4.33%)` | :arrow_down: | | [magma/tuple.py](https://app.codecov.io/gh/phanrahan/magma/pull/1333?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bWFnbWEvdHVwbGUucHk=) | `88.84% <68.75%> (-1.16%)` | :arrow_down: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
.value()whereiswholewould incorrectly return True when two tuples with different key orderings were wired (it's ok to wire two tuples when there keys don't match if you wire the children up explicitly, but.value()shouldn't return the source tuple because that's not a compatible type, instead it should construct a new flipped version)._to integer keys)