phanrahan / magma

magma circuits
Other
253 stars 24 forks source link

Warning when wiring enable using __call__ syntax #1364

Open leonardt opened 8 months ago

leonardt commented 8 months ago

See https://github.com/phanrahan/magma/pull/1363/files for an example, likely due to the normal call logic skipping clock types. I think this logic is there to allow wiring of registers using call without having to explicitly provide the clock.

I think if the argument is explicitly provided like in the example above, the warning shouldn't fire.

leonardt commented 8 months ago

Warning example

image

Note: it may be that the wiring is working fine but the warning is a false positive