phantamanta44
commented
2 years ago this is very good work, but i have a few concerns:
- the number over the slot and the submit button are important and should not be removed
- the point is that the text box and submit button are the user's UI and the number over the slot is the actual state of the level maintainer
- this way, if they get desynchronized, the user can see both numbers
- the correct fix, then, would be to first check that the gui is correct for the level maintainer getting the update packet, then to not change the text boxes (and only allow the number over the slot to change)
- (this leaves the problem of the player not being able to see the actual batch size. maybe this could be displayed over the slot when shift is held or something?)
- the enter button should stay as the submit button
- generally, enter should never be used for navigation because it's unintuitive
- also, text boxes should never commit changes without explicit user submission
- this avoids, for example, the AE2 network requesting a billion items because the user made a typo and it auto-committed
- it seems like your IDE ran auto-format, and it messed up a bunch of random bits of code. this should be avoided if possible
- i can send you my IDEA formatting config if you need it
i also have some comments about the libnine changes, but i'll leave them on that PR
Fix Level Maintainer fields "updating" Remove number in slot, it's redundant as you have a number in a field near it Add a couple of digits max to numbers, so it goes not to 10^6 max but to 10^8 Remove checkmarks and have numbers instantly registering when user inputs them Making Enter go to next line(batch1 to batch2, qty1 to qty2), Tab to next entry(so to batch1 from qty1, or qty2 from batch1) "Delete" to clear a field Typing "k" in a field will type 000, for easy thousands entering