search

phantamanta44 / ae2-fluid-crafting

experimental fluid autocrafting for ae2
https://www.curseforge.com/minecraft/mc-mods/ae2-fluid-crafting
Other
16 stars 10 forks source link

Dual Interface #10

Closed Yefancy closed 3 years ago

Yefancy commented 4 years ago

Sorry for my sloppy in my previous work. However, this two days I reimplemented ME Dual Interface according to the problem mentioned earlier. It mainly includes the following contents:

My own test runs well, but there may be some unknown bugs. This PR is a little hurry. Because ae2fc is updated frequently on the core framework recently, and I hope to avoid some conflicts.

Yefancy commented 4 years ago

Still there?

phantamanta44 commented 4 years ago

sorry, been extremely busy with schoolwork. i'll take a look at this when i have a chance to, but that might be a while

Yefancy commented 4 years ago

yes, rl is more important, best wishes for you then.

phantamanta44 commented 4 years ago

wow, that's a lot of work. hopefully, i'll be able to go over this by the end of the week...

Yefancy commented 3 years ago

It looks like you're still busy.

phantamanta44 commented 3 years ago

as it would happen, my thanksgiving break just started today, so i'll finally be able to look at this

phantamanta44 commented 3 years ago

alright, this is broadly very good work, but there are a few small things I would want implemented differently. I'm thinking about just merging and making the changes myself; is this an okay resolution with you?

Yefancy commented 3 years ago

Of course. After all, it's your stuff, and I only expect such features. Have a nice break.

phantamanta44 commented 3 years ago

cool! thanks for all your hard work. if you have a curseforge account, I can add you as a contributor there, if you'd like

Yefancy commented 3 years ago

I have no curse forge account. It doesn't matter, and I'm happy to contribute to this mod.