[1.12.2] Weird Damage Boost with the Ruination Trait?

[SonicX8000]

I dunno how to go about explaining this but it seems that the damage bonus from this trait is a bit iffy, as it depends on what tool you're using and even if you had the attack damage be right near each other. So... here's some testing that I've been doing.

Battleaxe is from Total Tinkers which has high base damage but comes at the cost of you taking more damage. It's like being a berserker where you don't mind taking quite a bit of damage here & there.

Explosive Bow is also from Total Tinkers which shoots bomb arrows that go boom. You have to create the materials yourself via json files but there are some default materials that you can use but for now... just going use the bow itself as a melee weapon for testing purposes.

Cleaver, Scythe and Broadsword are... vanilla tinkers tools, so... yea.

ToroHUD is being used to show damage pop-offs although it tends to round up the damage. For these tests I am using an Iron Golem that has 16662 Health which is due to Scaling Health increasing it's health stat.

---

All-Iron Battleaxe: 10.5 Attack Damage. Hits 11 Damage.

All-Iron Cleaver: 10.84 Attack Damage. Hits 11 Damage.

All-Iron Broadsword: 6 Attack Damage. Hits 6 Damage.

All-Iron Scythe: 4 Attack Damage. Hits 4 Damage.

All Iron Explosive Bow String: 3.8 Attack damage. Hits 4 Damage.

=====

Now here is where I toss in Void Metal in order to get the Ruination trait as well as getting their damage close to each other via Sharp or other damage boosting modifiers/traits/materials.

All-Iron Battleaxe but the Handle is Void Metal: 10.5 Attack Damage. Hits for 433, 424, 416, 407... Damage.

All-Iron Cleaver but the Handle is Void Metal: 10.84 Attack Damage. Hits for 221, 220, 219, 218... Damage.

All Iron Broadsword but the Handle is Void Metal & has Sharpester (133/144): 10.5 Attack Damage. Hits for 146, 146, 146, 145... Damage.

All Iron Scythe but the Handle is Void Metal & has Sharper (286/288): 10.5 Attack Damage. Hits for 146, 146, 146, 145... Damage.

All-Magma Slime String Explosive Bow but the Tough Binding is Void Metal & has Sharpester (252/288): 10.51 Attack Damage. Hits for 146, 146, 146, 145... Damage.

---

I may have to do some more tests to be sure, but something kinda feels... off. Like the damage boost depends on the tool itself even if their attack damage are nearly the same. Also... the Ruination Bonus was put at 3% instead of the default 4%.

[phantamanta44]

did you have the damage cutoff disabled for this? these numbers seem reasonably consistent with the cutoff values for those weapons