search

phantamanta44 / tinkers-evolution

the fresh new tinkers' construct addon
https://www.curseforge.com/minecraft/mc-mods/tinkers-evolution
Other
24 stars 15 forks source link

The modifier 'Astral' of the TconEvo has some problems #127

Closed EdwinYoungSteve closed 10 months ago

EdwinYoungSteve commented 1 year ago

If you custom the TIC material (using pewter or contenttweaker) with the Astral Modifier, The tool's NBT which has this modifier will be cleared when attuned on the attunement altar.

Thanks.

EdwinYoungSteve commented 1 year ago

image image image image

EdwinYoungSteve commented 1 year ago

@LXGaming here are the details

Krutoy242 commented 10 months ago

Can confirm, happens to E2E-E player too:

image

phantamanta44 commented 10 months ago

ok, i've figured out that in e2e:e, it's a conflict with random tweaker, which does essentially the same coremod hack as tconevo to mess with the attunement altar. not sure if that's also the same problem as the OP

Krutoy242 commented 10 months ago

Should i report it to random tweaker mod issues?

phantamanta44 commented 10 months ago

i plan on changing the way my patch works so that it's less intrusive, and so the random patches guys shouldn't need to do anything on their end. it might still be useful to let them know that this conflict can happen, i guess?

phantamanta44 commented 10 months ago

really the problem is that the astral sorcery attunement altar code is not designed for this sort of thing at all, but of course AS 1.12 is no longer supported, so there's no chance of any fix happening there

Krutoy242 commented 9 months ago

Voiding NBT data on AS infusion wasn't fixed. Players still report this issue even on version tconevo-1.12.2-1.0.48

https://github.com/Krutoy242/Enigmatica2Expert-Extended/issues/318

How can i avoid voiding TCon tools?

phantamanta44 commented 9 months ago

that's a bit embarrassing, but I'll chalk it up to being rusty after taking such a long break