phantomate / Untare

Flutter app for tandoor recipes
GNU General Public License v3.0
105 stars 11 forks source link

Cannot set name to recipe (Expects a number < 128) #91

Closed Piztou closed 3 months ago

Piztou commented 3 months ago

Bug Summary

I cannot edit or create a new recipe without having to set the name to a number.

Any int or decimal number seems to currently work as long as it's below 128 (ex , -325, 129e-1,...). But not any extra chars.

I'm guessing the system checks the max value instead of the max size of the input.

Reproduction Steps

On Android 14, using the latest version on the Play Store, create a new recipe, or edit any existing one.

Expected Results

Being able to keep/set a proper name for the recipe, not a number

Actual Results

The Name fields gets highlighted in red with the message Value must be less than or equal to 128, which prevents from saving the changes

Checklist

Piztou commented 3 months ago

Just discovered this lovely app, and it seems to work fine apart from this issue, so thanks a lot for making it, and offering it for free!

I've never developed any Flutter app, and I do not have any environment setup to test it but it seems it could be coming from this line : https://github.com/phantomate/Untare/blame/a61b83a56e93e4c7b58d4e1c1cb0dcca967d1cda/lib/pages/recipe_upsert_page.dart#L447

A maxLength(128)could maybe be more appropriate ?

phantomate commented 3 months ago

Hi, you are right, I updated the form widget in the last version and it seems that is broke something. I'm currently not in town so it will take some days for me to fix it.

serrq commented 3 months ago

Is it the same issue of mine?

1000116098

serrq commented 3 months ago

Keywords are lost during import (via URL) after press on "save" button.

1000116101