Chrome allow additional options and allow redirecting child output

phantombuster / nickjs

Web scraping library made by the Phantombuster team. Modern, simple & works on all websites. (Deprecated)

https://nickjs.org

ISC License

500 stars 48 forks source link

Chrome allow additional options and allow redirecting child output #63

Closed bogdanRada closed 4 years ago

bogdanRada commented 5 years ago

Allow2 additional options to be passed to chrome and Casper I need this functionality to be able to pass these options to chrome '--ignore-certificate-errors', '--ignore-urlfetcher-cert-requests'
Also ability to redirect child output diffrently . I need this because i want child stderr to write to stdout

Please let me know if any changes are needed. Thank you

bogdanRada commented 4 years ago

any updates on this? I really need the possibility to pass additional options to the chrome driver at least.

paps commented 4 years ago

Hey, sorry for the delay and thanks for the PR. I don't see why I would not merge this :)

bogdanRada commented 4 years ago

hello @paps , thanks for merging this into master. Can this also be released on https://yarnpkg.com/en/package/nickjs ? I still see version 0.3.6. Can we bump it to 0.3.7 please? Thank you very much

paps commented 4 years ago

Done. 0.3.7 is up