search

phantombuster / nickjs

Web scraping library made by the Phantombuster team. Modern, simple & works on all websites. (Deprecated)
https://nickjs.org
ISC License
500 stars 48 forks source link

Fix verification for childStdout and childStderr and update readme #73

Closed bogdanRada closed 4 years ago

bogdanRada commented 4 years ago

Hello I recently made a PR https://github.com/phantombuster/nickjs/pull/63, but it seems i didn't tested properly the options childStdout and childStderr I fixed now the verification and also updated the readme

Please let me know if there is anything else that needs updating. Also could we please release this fix to https://yarnpkg.com too please? thank you very much

bogdanRada commented 4 years ago

@paps , can you please review this too ? Thank you very much

bogdanRada commented 4 years ago

Hello @paps Thank you very much for merging this PR into master branch. Can you please also release the changes to https://yarnpkg.com too? That would really be great. Thank you very much

paps commented 4 years ago

Hey, sorry for the huge delay. I've just published the package :hugs:

This is most certainly the last publish we'll do, it includes a depreciation notice in the readme. You should probably look into switching to Puppeteer or Playwright!