phantomcyber / phantom-apps

Phantom Apps Repo
Apache License 2.0
82 stars 166 forks source link

phslack: adding requirements.txt and building wheels #785

Closed jdemelo closed 3 years ago

jdemelo commented 3 years ago

PAPP-20799:

Testing:


Please ensure your pull request (PR) adheres to the following guidelines:

Pull Request Checklist

Please check if your PR fulfills the following requirements:

Please check the type of change your PR introduces:

Release Notes (REQUIRED)

What is the current behavior? (OPTIONAL)

What is the new behavior? (OPTIONAL)

Other information (OPTIONAL)

Pay close attention to (OPTIONAL)

Screenshots (if relevant)


Thanks for contributing!

rgil-splunk commented 3 years ago

ngl, at first glance I saw 47 files changed and thought either something went wrong or the title was wrong saying just the slack app 😂

jdemelo commented 3 years ago

ngl, at first glance I saw 47 files changed and thought either something went wrong or the title was wrong saying just the slack app 😂

Haha, yep, understandable! I wasn't expecting so many files in dependencies.