search

phanx-wow / Badapples

WoW AddOn — Stores the names of players you don't want to ever group with.
Other
0 stars 0 forks source link

Occasional taint #1

Open Phanx opened 9 years ago

Phanx commented 9 years ago

Originally posted by Dridzt on WoWInterface:

7/9 00:28:48.389  Global variable FriendsFrame_Update tainted by Badapples - Interface\AddOns\Badapples\BadapplesFix.lua:70
7/9 00:28:48.389  Execution tainted by Badapples while reading FriendsFrame_Update - Interface\FrameXML\FriendsFrame.lua:257
7/9 00:28:48.389      FriendsFrame:Show()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:1800 <unnamed>:SetUIPanel()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:1644 <unnamed>:ShowUIPanel()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:1531
7/9 00:28:48.389      <unnamed>:SetAttribute()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:2243 ShowUIPanel()
7/9 00:28:48.389      Interface\FrameXML\FriendsFrame.lua:1144 ToggleFriendsFrame()
7/9 00:28:48.389      TOGGLESOCIAL:1
7/9 00:28:48.389  Interface\FrameXML\FriendsFrame.lua:257
7/9 00:28:48.389  An action was blocked in combat because of taint from Badapples - RaidFrame:Show()
7/9 00:28:48.389      Interface\FrameXML\FriendsFrame.lua:81 FriendsFrame_ShowSubFrame()
7/9 00:28:48.389      Interface\FrameXML\FriendsFrame.lua:310
7/9 00:28:48.389      FriendsFrame_Update()
7/9 00:28:48.389      Interface\FrameXML\FriendsFrame.lua:257
7/9 00:28:48.389      FriendsFrame:Show()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:1800 <unnamed>:SetUIPanel()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:1644 <unnamed>:ShowUIPanel()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:1531
7/9 00:28:48.389      <unnamed>:SetAttribute()
7/9 00:28:48.389      Interface\FrameXML\UIParent.lua:2243 ShowUIPanel()
7/9 00:28:48.389      Interface\FrameXML\FriendsFrame.lua:1144 ToggleFriendsFrame()
7/9 00:28:48.389      TOGGLESOCIAL:1

This is the entirety of the taint.log not an excerpt and the symptom is raidframes not showing/refreshing properly for units added /removed.

Phanx commented 9 years ago

This is (probably) caused by the use of Blizzard's panel tab system, or at least the use of it on the friends frame. At some point I will rewrite things to avoid using any Blizzard stuff, but it's a low priority.