phanxgames / AetherStory

Bug Tracker for Aether Story
https://www.aetherstory.com
2 stars 1 forks source link

trading gold leads to gold loss with both players #210

Closed sameluck closed 2 years ago

sameluck commented 2 years ago

Describe the bug after trading both players lose the gold they offered

To Reproduce Steps to reproduce the behavior: 1.initiate trade with someone 2.both players involved in a trade add gold to it 3.confirming trade should cause a gold decrease for both players

Expected behavior one player loses gold and one player gains it

Screenshots none

Context:

Additional context full description as given on discord: "found a bug exchanging gold and I lost all my and my mates gold" "so what happened was my mate wanted to buy some gear so I traded some gold with him he also gave me a little bit so I wouldnt be without any gold so he would spend exact but when we checked our bags. he didnt have the gold I sent him and I didnt have the amount he sent me"

phanxgames commented 2 years ago

Test Results for gold for gold trading:

STARTED 
joe peg
111244  88

TRADED  
joe peg
4   2

EXPECTED    
joe peg
111242  90

RESULT  
joe peg
111246  86

Conclusion: Joe's gold transfer was overwritten by peg's gold transfer.

EDIT: However, these results do not match the description by OP. They are claiming that gold is being lost. The test results do not show a net loss. If gold is actually being lost/eaten to the void, then this is a critical error.

But I do not see that happening in my tests. In no situation does gold vanish. Only one half of the trade occurs, and the other half is safely ignored.

Need more info.

phanxgames commented 2 years ago

This should be fixed in the next patch.