search

phanxipang / fansipan

A simple package that allows you to write your API integrations or SDKs in a elegant way.
https://phanxipang.github.io/fansipan
MIT License
81 stars 2 forks source link

Plagiarized docs #21

Closed Sammyjo20 closed 9 months ago

Sammyjo20 commented 9 months ago

Hey @jenky

I noticed that this library has plagiarised a lot of my documentation from my library, Saloon: https://docs.saloon.dev/

The introduction of your documentation is almost exactly the same as my documentation from a few versions ago

Screenshot 2023-11-27 at 14 42 46

Saloon's Docs:

Screenshot 2023-11-27 at 14 43 33

I also noticed quite a few other pages have been simply copied and not re-written.

I'm flattered that people are writing similar libraries to Saloon, but I'm not cool with people copying the writing that I spent a lot of time on.

Sammyjo20 commented 9 months ago

Also, to be clear - I think your implementation is cool - it's clear you have spent a lot of time on the codebase and made changes that reflect your opinions on things which is awesome, so nice work on the library. I am just worried this was someone blindly copying and pasting my work.

jenky commented 9 months ago

Thank you for sharing your opinion and feedback. Regarding the document, I will update it soon.

To be honest, I created this when your salon was in its early version 1. Although your concept was very cool, there were a few things that I wanted to do differently. After careful consideration, I realized that the APIs would be different, so I decided to create my own version. The main factors that influenced my decision were the monolith I am currently working on, which is still on PHP7 😂. Additionally, as the SDK developer, I believe it is reasonable to target a wider user base because upgrading a legacy codebase is a nightmare and requires significant effort to accomplish. Sometimes, from a business perspective, it doesn't matter as long as it works, so you just have to deal with it 🤷. Happy coding 🧑‍💻!

Sammyjo20 commented 9 months ago

Thanks @jenky, and I apologise for my initial abruptness. Had a stressful day.

I was having a read through of your library and I really like some of the design decisions that you made. I hope this package is successful!

Take care and happy coding too 🤠