search

phar-io / composer-distributor

Distribute PHAR files via Composer
Other
12 stars 2 forks source link

Fix key directory issue #13

Closed sebastianfeldmann closed 3 years ago

sebastianfeldmann commented 3 years ago

The issue with the keyDirectory was the path resolving. The config is not validating the path to the keyDirectory so I switched the return type back to string. The validation is now happening during the KeyDirectory creation. For this I added the new KeyNotFound exception. I added some extra whitespaces to the download and verification output so it is better aligned with the composer output.

There are also some type hint additions and some file header removals.

heiglandreas commented 3 years ago

Did we mix up different things in one commit here? :wink:

sebastianfeldmann commented 3 years ago

Version 0.3.1 is now working

composer install --no-cache
No lock file found. Updating dependencies instead of installing from lock file. Use composer update over composer install if you do not have a lock file.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 5 installs, 0 updates, 0 removals
  - Locking captainhook/captainhook-phar (5.4.2)
  - Locking phar-io/composer-distributor (0.3.1)
  - Locking phar-io/executor (0.9.0)
  - Locking phar-io/filesystem (0.9.0)
  - Locking phar-io/gnupg (0.9.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 5 installs, 0 updates, 0 removals
  - Downloading phar-io/filesystem (0.9.0)
  - Downloading phar-io/executor (0.9.0)
  - Downloading phar-io/gnupg (0.9.1)
  - Downloading phar-io/composer-distributor (0.3.1)
  - Downloading captainhook/captainhook-phar (5.4.2)
  - Installing phar-io/filesystem (0.9.0): Extracting archive
  - Installing phar-io/executor (0.9.0): Extracting archive
  - Installing phar-io/gnupg (0.9.1): Extracting archive
  - Installing phar-io/composer-distributor (0.3.1): Extracting archive
  - Installing captainhook/captainhook-phar (5.4.2): Extracting archive
    Downloading artifact in version 5.4.2 from https://github.com/captainhookphp/captainhook/releases/download/5.4.2/captainhook.phar
    PHAR signature successfully verified
Generating autoload files

Important bits

    ...
  - Installing captainhook/captainhook-phar (5.4.2): Extracting archive
    Downloading artifact in version 5.4.2 from https://github.com/captainhookphp/captainhook/releases/download/5.4.2/captainhook.phar
    PHAR signature successfully verified