phar-io / phive

The Phar Installation and Verification Environment (PHIVE)
https://phar.io
BSD 3-Clause "New" or "Revised" License
579 stars 43 forks source link

JsonData::parsed may not be an array #193

Open szepeviktor opened 5 years ago

szepeviktor commented 5 years ago

getFragment() will not be able to process it

https://github.com/phar-io/phive/blob/master/src/shared/JsonData.php#L24

theseer commented 5 years ago

Known problem:

https://scrutinizer-ci.com/g/phar-io/phive/issues/master/files/src/shared/JsonData.php?selectedLabels%5B0%5D=9&orderField=path&order=asc&honorSelectedPaths=0

It should probably be changed to be assoc=true and thus only use array.