phar-io / phive

The Phar Installation and Verification Environment (PHIVE)
https://phar.io
BSD 3-Clause "New" or "Revised" License
579 stars 43 forks source link

Enhancement: Link `/repo/` to `/github/workspace/` #395

Closed localheinz closed 1 year ago

localheinz commented 1 year ago

This pull request

💁‍♂️ I am unsure how to mount a volume when using a Docker image in a GitHub Actions step. However, as you can see in https://github.com/ergebnis/playground/actions/runs/4053829531/jobs/6974917526#step:10:13, GitHub mounts the GitHub workspace directory, e.g., /home/runner/work/playground/playground to /github/workspace, so by creating a symbolic link from /github/workspace to /repo should make the failing workflow referenced above pass.

What do you think?

localheinz commented 1 year ago

Not sure if that even makes sense.

theseer commented 1 year ago

I understand the reasoning but no:

What we could consider doing is creating a dedicated image on ghcr.io for this purpose, based on the "offical" build image (we can't use the stripped image because it doesn't contain mkdir and ln). I wouldn't know how to do that though as of yet ;)