search

phar-io / phive

The Phar Installation and Verification Environment (PHIVE)
https://phar.io
BSD 3-Clause "New" or "Revised" License
579 stars 43 forks source link

Sort the list of aliases alphabetically #409

Closed nicwortel closed 1 year ago

nicwortel commented 1 year ago

This will make it easier to find a specific alias in the list, and groups related aliases together.

Fixes https://github.com/phar-io/phive/issues/408.

nicwortel commented 1 year ago

Screenshot of the output after this change:

image

PHPUnit tests are passing as well, but GitHub Actions don't run until the workflow is approved.

nicwortel commented 1 year ago

It seems like the tests fail on older PHP versions because Phive tries to install PHPUnit 10 (which only supports PHP 8.1 and higher).

image

We should probably fix PHPUnit to version 9 in .github/workflows/integrate.yaml.

Shall I do so in this PR or create a separate PR for it?

theseer commented 1 year ago

It seems like the tests fail on older PHP versions because Phive tries to install PHPUnit 10 (which only supports PHP 8.1 and higher).

image

We should probably fix PHPUnit to version 9 in .github/workflows/integrate.yaml.

Shall I do so in this PR or create a separate PR for it?

Nice catch. For sake of cleanliness a separate PR is probably nicer ;)

theseer commented 1 year ago

Can you rebase this so we get the change in here? :)

theseer commented 1 year ago

Thanks a lot!