search

pharmaR / regulatory-r-repo-wg

Package consensus for regulated industries
https://pharmar.github.io/regulatory-r-repo-wg
27 stars 3 forks source link

branch protection / workflow #27

Closed kkmann closed 1 year ago

kkmann commented 1 year ago

@dgkf Would suggest to implement a branch protection rule for main (changes only via PR, 1+ reviewer) to keep things tidy. Make squash ff default?

yannfeat commented 1 year ago

@dgkf Would suggest to implement a branch protection rule for main (changes only via PR, 1+ reviewer) to keep things tidy. Make squash ff default?

Shouldn't we set an example for future validated packages and avoid using squash commits? I think that squash commits could be considered bad coding practices for validated environments in the future, as they decrease transparency.

I would advocate instead for highly informative commit messages, including a traditional 50 characters summary, but also, if useful, a detailed description (using for example this approach).

kkmann commented 1 year ago

@yannfeat this is really just for our repo here, in terms of recommendations for developing statistical software (R apckages) I would recommend heading over to https://rconsortium.github.io/asa-biop-swe-wg/join_us.html :)

kkmann commented 1 year ago

@dgkf bump.

kkmann commented 1 year ago

done.