search

pharmaR / regulatory-r-repo-wg

Package consensus for regulated industries
https://pharmar.github.io/regulatory-r-repo-wg
27 stars 3 forks source link

Quarto website #42

Closed yannfeat closed 1 year ago

yannfeat commented 1 year ago

Tested on a fork, it now works: https://yannfeat.github.io/regulatory-r-repo-wg

Write access is needed for GitHub actions: image

dgkf commented 1 year ago

Just one other thought - can we also introduce a .gitignore file with some standard quarto artifacts so that we avoid accidentally committing artifacts when making changes? (.html, _site, site_libs, _freeze)

yannfeat commented 1 year ago

Just one other thought - can we also introduce a .gitignore file with some standard quarto artifacts so that we avoid accidentally committing artifacts when making changes? (.html, _site, site_libs, _freeze)

I added it to the gh-pages branch, that it used to deploy the website. No Quarto artifact should be committed to the main branch.

dgkf commented 1 year ago

I added it to the gh-pages branch, that it used to deploy the website. No Quarto artifact should be committed to the main branch.

I saw that - from a CI/CD perspective that part looks totally fine.

I was suggesting it primarily as a safety measure for situations where someone is preparing changes to the webpage and have generated artifacts locally. In those situations, its nice to have git ignore all the artifact extensions so that you can still do a git add * and not have to worry about accidentally introducing artifacts into a commit.

yannfeat commented 1 year ago

I added it to the gh-pages branch, that it used to deploy the website. No Quarto artifact should be committed to the main branch.

I saw that - from a CI/CD perspective that part looks totally fine.

I was suggesting it primarily as a safety measure for situations where someone is preparing changes to the webpage and have generated artifacts locally. In those situations, its nice to have git ignore all the artifact extensions so that you can still do a git add * and not have to worry about accidentally introducing artifacts into a commit.

OK, it is done.

yannfeat commented 1 year ago

@dgkf I get a 404 error when trying to access the website, I think the write permission has to be granted by an admin in the settings

dgkf commented 1 year ago

@dgkf I get a 404 error when trying to access the website, I think the write permission has to be granted by an admin in the settings

No worries, I got it sorted out. We just needed to configure the Pages settings to use the gh-pages branch as its source.