Closed AARON-CLARK closed 1 year ago
OK I'll create a PR for these, @AARON-CLARK
Here is the updated "Remove Package(s)" button
adding version to "Summary of Removed Packages"
@AARON-CLARK & @Robert-Krajcik
I know the PR addressing this issue has already been merged, but can we change the border to the delete button as well? Red border on blue background is offending my eyes.
can we change the border to the delete button as well?
@Jeff-Thompson12, of course!
closed with #369
Soo...I'm reopening because I noticed that when you click on the button a "shadow" appears and the "shadow" is red.
@Robert-Krajcik I also noticed that even though the delete option is not present for admin users, the introJS
still has a section for it.
Good catch @Jeff-Thompson12 on the introJS
I'll make another PR for this and the "button shadow" issue.
Finally closed with PR #401 rk 366 edits_del_option2
Hi @Robert-Krajcik,
I was just starting a review your PR #352 when @Jeff-Thompson12 finished his review and merged. No big deal, but I thought I'd add my comments here:
First, could we change the color of this button so that it really pops against the rest of the page? I think we should visually indicate that this button is "special". Maybe a light blue?
Secondly, I thought it probably matters to include the pkg's version number in this summary table since we are storing it in the DB: