pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
101 stars 29 forks source link

Edits to "Pkg Delete" Option #366

Closed AARON-CLARK closed 1 year ago

AARON-CLARK commented 1 year ago

Hi @Robert-Krajcik,

I was just starting a review your PR #352 when @Jeff-Thompson12 finished his review and merged. No big deal, but I thought I'd add my comments here:

First, could we change the color of this button so that it really pops against the rest of the page? I think we should visually indicate that this button is "special". Maybe a light blue?

image

Secondly, I thought it probably matters to include the pkg's version number in this summary table since we are storing it in the DB:

image

Robert-Krajcik commented 1 year ago

OK I'll create a PR for these, @AARON-CLARK

Robert-Krajcik commented 1 year ago

Here is the updated "Remove Package(s)" button image

Robert-Krajcik commented 1 year ago

adding version to "Summary of Removed Packages" image

Jeff-Thompson12 commented 1 year ago

@AARON-CLARK & @Robert-Krajcik

I know the PR addressing this issue has already been merged, but can we change the border to the delete button as well? Red border on blue background is offending my eyes.

AARON-CLARK commented 1 year ago

can we change the border to the delete button as well?

@Jeff-Thompson12, of course!

AARON-CLARK commented 1 year ago

closed with #369

Jeff-Thompson12 commented 1 year ago

Soo...I'm reopening because I noticed that when you click on the button a "shadow" appears and the "shadow" is red.

image

Jeff-Thompson12 commented 1 year ago

@Robert-Krajcik I also noticed that even though the delete option is not present for admin users, the introJS still has a section for it.

Robert-Krajcik commented 1 year ago

Good catch @Jeff-Thompson12 on the introJS I'll make another PR for this and the "button shadow" issue.

Robert-Krajcik commented 1 year ago

Finally closed with PR #401 rk 366 edits_del_option2