pharmaR / riskassessment

Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
98 stars 26 forks source link

Add comment module to function explorer #665

Closed Jeff-Thompson12 closed 9 months ago

Jeff-Thompson12 commented 9 months ago

Addresses #643

codecov[bot] commented 9 months ago

Codecov Report

Merging #665 (d114ee4) into dev (ebb184e) will increase coverage by 0.15%. Report is 19 commits behind head on dev. The diff coverage is 91.66%.

:exclamation: Current head d114ee4 differs from pull request most recent head bc42587. Consider uploading reports for the commit bc42587 to get more accurate results

@@            Coverage Diff             @@
##              dev     #665      +/-   ##
==========================================
+ Coverage   72.78%   72.94%   +0.15%     
==========================================
  Files          33       33              
  Lines        4781     4827      +46     
==========================================
+ Hits         3480     3521      +41     
- Misses       1301     1306       +5     
Files Coverage Δ
R/mod_addComment.R 96.87% <100.00%> (+0.10%) :arrow_up:
R/mod_databaseView.R 91.22% <100.00%> (+0.43%) :arrow_up:
R/mod_downloadHandler.R 66.84% <100.00%> (+0.35%) :arrow_up:
R/mod_reportPreview.R 79.23% <100.00%> (+1.27%) :arrow_up:
R/utils_get_db.R 86.77% <100.00%> (+0.68%) :arrow_up:
R/mod_code_explorer.R 26.47% <64.28%> (+6.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Jeff-Thompson12 commented 9 months ago

@AARON-CLARK Can you tell me which preferences you had selected for the report output?

Robert-Krajcik commented 9 months ago

Hi @Jeff-Thompson12 You might need to merge in the latest changes in dev

AARON-CLARK commented 9 months ago

@AARON-CLARK Can you tell me which preferences you had selected for the report output?

@Jeff-Thompson12, all elements were included / checked.

Jeff-Thompson12 commented 9 months ago

@AARON-CLARK It appears that the usage of kableExtra for constructing the community usage metrics could cause the download to go into limbo. I have opted to remove it since we need a more elegant solution anyways.