Fix a few bugs with choosing report options

[Jeff-Thompson12]

Addresses #666 and #667

[codecov[bot]]

Codecov Report

Merging #668 (d94a024) into dev (d114ee4) will increase coverage by 0.01%. Report is 1 commits behind head on dev. The diff coverage is 83.07%.

:exclamation: Current head d94a024 differs from pull request most recent head 930a19c. Consider uploading reports for the commit 930a19c to get more accurate results

@@            Coverage Diff             @@
##              dev     #668      +/-   ##
==========================================
+ Coverage   72.94%   72.96%   +0.01%     
==========================================
  Files          33       33              
  Lines        4827     4834       +7     
==========================================
+ Hits         3521     3527       +6     
- Misses       1306     1307       +1     

Files	Coverage Δ
R/app_server.R	79.45% <100.00%> (+1.43%)	:arrow_up:
R/mod_downloadHandler.R	65.74% <100.00%> (-1.10%)	:arrow_down:
R/mod_reportPreview.R	79.23% <100.00%> (ø)
R/mod_reweightView.R	95.67% <100.00%> (ø)
R/mod_sidebar.R	96.11% <100.00%> (+0.01%)	:arrow_up:
R/mod_packageDependencies.R	18.77% <0.00%> (ø)
R/mod_user_roles.R	29.22% <0.00%> (ø)
R/mod_databaseView.R	89.88% <82.35%> (-1.35%)	:arrow_down:
R/mod_uploadPackage.R	76.86% <75.00%> (+0.11%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Jeff-Thompson12]

This PR also re-envisions the usage of trigger_events. Instead of defining a reactive values object in the server and then passing that object to all modules, it assigns the object to session$userData so that all modules can access it without it being passed in the arguments.

[Jeff-Thompson12]

It appears that the "Explore Metrics" column is also visible when deleting packages which is not desirable either

[Robert-Krajcik]

I had left the "Explore Metrics" column in the "SUMMARY OF REMOVED PACKAGE(S)" but removed the Action button. If you want to remove the column, that's fine.

So bottom line, The "Explore Metrics" button takes you to whatever sub-tab is open under "Package Metrics" (default is "Maintenance Metrics")

[Jeff-Thompson12]

@Robert-Krajcik I have incorporated fixes for the bugs you found. I guess this PR has turned mostly into a squash bugs PR. Any other bugs?

[Robert-Krajcik]

No other bugs encountered, @Jeff-Thompson12 I will give this a good run-through in a few minutes