pharmaR / riskassessment

Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
98 stars 26 forks source link

Fix `selectizeInput()` on `Upload Pkgs` tab #683

Closed AARON-CLARK closed 8 months ago

AARON-CLARK commented 8 months ago

Ensures users can not create and select packages from CRAN that don't exist

AARON-CLARK commented 8 months ago

Hey @Jeff-Thompson12, just thought I'd add this quick fix to v3.0.0 too. One thing I couldn't figure out yet is how to allow for auto completion when pressing tab. If that's not possible, we can merge without.

Jeff-Thompson12 commented 8 months ago

@AARON-CLARK I just enabled selection on TAB. Please note that a user can no longer tab out of the select input to the button now since whichever option is highlighted will be selected.

codecov[bot] commented 8 months ago

Codecov Report

Merging #683 (63854cf) into dev (14159ab) will decrease coverage by 0.05%. Report is 1 commits behind head on dev. The diff coverage is 100.00%.

:exclamation: Current head 63854cf differs from pull request most recent head 43c6dda. Consider uploading reports for the commit 43c6dda to get more accurate results

@@            Coverage Diff             @@
##              dev     #683      +/-   ##
==========================================
- Coverage   73.02%   72.98%   -0.05%     
==========================================
  Files          33       33              
  Lines        4830     4830              
==========================================
- Hits         3527     3525       -2     
- Misses       1303     1305       +2     
Files Coverage Δ
R/mod_uploadPackage.R 76.75% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more