`renv` feedback post `v3.0.0` release

pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment

https://pharmar.github.io/riskassessment/

Other

101 stars 28 forks source link

`renv` feedback post `v3.0.0` release #690

Closed AARON-CLARK closed 9 months ago

AARON-CLARK commented 11 months ago

Some feedback from some partners at ProCogia

This time, recreating the development environment was smoother, largely due to the migration to 'shinyTree'. However, I encountered some package version issues with svglite (1.2.3), pkgload (1.3.3), and rlang (1.1.1). Resolving these by updating them to the versions specified in parentheses ‘()’ in the renv.lock file allowed me to successfully recreate the environment.
After making these changes, I successfully got the Shiny application up and running on my local machine.

AARON-CLARK commented 11 months ago

Follow up: ask what the "issues" were that he encountered. svglite is a downgrade and the other two are an upgrade.

mayank-procogia commented 10 months ago

An updated renv fix is available at https://github.com/mayank-procogia/riskassessment/tree/dev_renv_fix This updated renv.lock version file has been successfully used to do riskassessment POC deployments in local, VM, and RS Connect.
Diff Commit: Link
Another observation is that this renv.lock configuration auto-repairs the dependency tree too.
Somerenv.lock updates are - R version change (due to my current system, checked for latest R v4.2.2 too), auto addition of new repo URLs, and addition of missing package dependencies.

Jeff-Thompson12 commented 10 months ago

@mayank-procogia can you please try this branch to see if it resolves your issues with renv? It utilizes a PPM snapshot and upgrades all packages (not installed from remotes) to be inline with the date of August 8, 2023.

mayank-procogia commented 10 months ago

Hi @Jeff-Thompson12, Thank you for your response. I tried to do a renv::restore() with the jt-690-repair_renvlock but it failed on my local (Mac) system.

Please have a look at my comments on issue #709 at

https://github.com/pharmaR/riskassessment/pull/709#issuecomment-1831511447 fixed by https://github.com/pharmaR/riskassessment/pull/709#issuecomment-1831713008
Updated my old renv.lock to use PPM as sole repo at https://github.com/pharmaR/riskassessment/pull/709#issuecomment-1831564184, and then forked latest changes from jt-690-repair_renvlock to do this same workflow step again at https://github.com/pharmaR/riskassessment/pull/709#issuecomment-1831635214

AARON-CLARK commented 9 months ago

closed with #709