search

pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
101 stars 28 forks source link

Ni 581 introjshandling #695

Closed narayanan-iyer-pfizer closed 10 months ago

narayanan-iyer-pfizer commented 11 months ago

As per title, tests might be failing, pls have a look

Jeff-Thompson12 commented 11 months ago

Here's a patch that will help you get farther along.

The main thing happening here is that when we run the application in a testing environment, we are pulling in internal data elements instead of running the riskmetric code and pulling data from CRAN. Since this is true, a tarball is never downloaded and untarred in the session, which also means that introJS is never displayed in the UI. This patch sets up the environment for the tidyr package.

narayanan-iyer-pfizer commented 11 months ago

Tests passed, pls review the changes

codecov[bot] commented 11 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (30325f8) 72.98% compared to head (0f86be6) 76.97%. Report is 1 commits behind head on dev.

Files Patch % Lines
R/mod_pkg_explorer.R 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #695 +/- ## ========================================== + Coverage 72.98% 76.97% +3.99% ========================================== Files 33 33 Lines 4830 4842 +12 ========================================== + Hits 3525 3727 +202 + Misses 1305 1115 -190 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.