search

pharmaR / riskassessment

Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
98 stars 26 forks source link

Fix privileges table problem #698

Closed Jeff-Thompson12 closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0e1e6b8) 72.98% compared to head (30325f8) 72.98%. Report is 1 commits behind head on dev.

:exclamation: Current head 30325f8 differs from pull request most recent head eaed857. Consider uploading reports for the commit eaed857 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #698 +/- ## ======================================= Coverage 72.98% 72.98% ======================================= Files 33 33 Lines 4830 4830 ======================================= Hits 3525 3525 Misses 1305 1305 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jeff-Thompson12 commented 8 months ago

@Robert-Krajcik I am pinging you for the review since you identified the bug. Note that I did create a test to make sure the used_privileges is aligned with privileges_tbl. I went ahead and created a testing file for the user roles module, but I did not populate it with a test for the module since that seems outside of the scope of this PR.