pharmaR / riskassessment

Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
98 stars 25 forks source link

Allow a non-credentialed deployment #703

Closed Jeff-Thompson12 closed 5 months ago

Jeff-Thompson12 commented 7 months ago

Addresses #700

codecov[bot] commented 7 months ago

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (12e418d) 78.12% compared to head (b6fb751) 77.19%.

Files Patch % Lines
R/mod_user_roles.R 1.09% 90 Missing :warning:
R/app_server.R 33.33% 6 Missing :warning:
R/mod_decision_automation.R 61.53% 5 Missing :warning:
R/mod_reportPreview.R 40.00% 3 Missing :warning:
R/utils_config_db.R 50.00% 3 Missing :warning:
R/utils_startup.R 81.81% 2 Missing :warning:
R/mod_addComment.R 75.00% 1 Missing :warning:
R/mod_communityMetrics.R 50.00% 1 Missing :warning:
R/mod_introJS.R 50.00% 1 Missing :warning:
R/mod_maintenanceMetrics.R 50.00% 1 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #703 +/- ## ========================================== - Coverage 78.12% 77.19% -0.94% ========================================== Files 33 33 Lines 4897 4964 +67 ========================================== + Hits 3826 3832 +6 - Misses 1071 1132 +61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AARON-CLARK commented 7 months ago

@Jeff-Thompson12, after recent merges, there is now a conflict on this branch.

AARON-CLARK commented 7 months ago

I think this looks really good. The only thing I would advise is to test out creating roles within our Posit Connect environment before merging. That way, we can see if they behave as we expect them to.

Nice work!