pharmaR / riskassessment

Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
98 stars 25 forks source link

Session Time Out with {Failed} bulk downloading #710

Open mayank-procogia opened 7 months ago

mayank-procogia commented 7 months ago

When trying to download a large batch render (HTML) and download as a Zip of all the packages (300+) present on the shiny apps deployment (https://rinpharma.shinyapps.io/riskassessment/), the rendering takes almost 1 hour and the application auto logs off from the current session. There is no error that is generated for the auto log off. This behaviour is reproducible with Shiny apps, Azure VM, AWS VM and RS Connect.

Similar experience on local machine setup as well.

AARON-CLARK commented 7 months ago

I discussed with Mayank on a call 12/1, where I described that we don't envision users rendering / downloading that many reports at once because the app is mostly likely just supporting a "more official" qualification process within the org that produces official documentation for regulatory agencies. Thus, the app's highest and best use is for users to generate a report to include with their "GxP package inclusion request", submitted to the org's governing body for the GxP env. However, with that said, most orgs would likely require that all the package's imports / dependencies' risk also be assessed, so assessing 1 pkg could turn into 25 pkgs pretty quickly.

In any respect, if we allow users to download 1 or 30 or 300 pkgs, we don't want the app to render for such a long time (especially since the rest of the app is locked until that process is finished) and we certainly don't want the app to crash. Let's explore two things:

  1. Move the rendering/knitting process to another process. Related to #711
  2. For downloading >= 10 reports, add a modal that asks the user to confirm their selection, warning them that "Rendering X reports at once will take some time. Are you sure you want to continue?" or something similar.
aclark02-arcus commented 5 days ago

Will be closed when #731 is merged.