search

pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
101 stars 28 forks source link

Fix GHAs for DOCX and PDF downloads #717

Closed Jeff-Thompson12 closed 9 months ago

Jeff-Thompson12 commented 10 months ago

Addresses #702

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (93f80f1) 77.17% compared to head (e4b004e) 78.14%.

:exclamation: Current head e4b004e differs from pull request most recent head 5a78a0f. Consider uploading reports for the commit 5a78a0f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #717 +/- ## ========================================== + Coverage 77.17% 78.14% +0.96% ========================================== Files 33 33 Lines 4872 4872 ========================================== + Hits 3760 3807 +47 + Misses 1112 1065 -47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jeff-Thompson12 commented 10 months ago

I have investigated printing the HTML reports to PDF. While some improvements can be made to make the reports nicer to print interactively, I do not think the work to get the reports to work programmatically is worth the effort (at least not in the short term).

Efforts would be better suited to determining which LaTeX packages are necessary to be able to print the DOCX and PDF versions of the report and to provide some user feedback if those packages are missing from the environment where the application is running.

Jeff-Thompson12 commented 10 months ago

I was able to get the PDF reports to work on the GHAs by installing the texlive-xetex package to get XeLatex.

Jeff-Thompson12 commented 10 months ago

I think this gives us a path forward to getting the downloads to work in deployments. Hopefully the steps to get the downloads to work on the GHAs will be similar to what will be needed on the deployment servers. The downside is that users will have to get their respective admins to install the necessary dependencies.

AARON-CLARK commented 9 months ago

To summarize a discussion with @Jeff-Thompson12 offline:

It's still on draft because I haven't actually fully resolved the deployment downloads.

I still have not created guidance for setting up that environment so that the reports can download...

... or figuring out how to determine if a report can compile. I feel like at least we should disable downloads that can't compile (if we can). Aka, provide some user feedback if those packages are missing from the environment where the application is running.

Jeff-Thompson12 commented 9 months ago

Per discussion today, I am changing the scope of this PR since the changes made benefit our workflow. I will open a new PR to tackle the download issues when the app is deployed.