search

pharmaR / riskassessment

Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
98 stars 25 forks source link

Run processes in background #731

Open Jeff-Thompson12 opened 6 months ago

Jeff-Thompson12 commented 6 months ago

Addresses #711

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 79.53488% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 78.78%. Comparing base (6bdf82d) to head (0db252b).

Files Patch % Lines
R/mod_downloadHandler.R 53.33% 35 Missing :warning:
R/mod_downloadHandler_utils.R 93.38% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #731 +/- ## ========================================== - Coverage 79.20% 78.78% -0.43% ========================================== Files 33 34 +1 Lines 5112 5171 +59 ========================================== + Hits 4049 4074 +25 - Misses 1063 1097 +34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jeff-Thompson12 commented 5 months ago

Looking for some feedback on this PR. Interested in what features you guys think should be added or what already needs to be changed.

Jeff-Thompson12 commented 3 months ago

@aclark02-arcus something else I forgot to mention is that since downloading a report is now a separate event from the report creation it is possible for the report downloader or another user to change outputs. This could be as low risk as adding comments but could also include actions like deleting a package from the database, which now that I mention it could crash the app.

aclark02-arcus commented 3 months ago

Converting to draft while we consider some alternatives, like grabbing info from database and injecting it into a list for rendering all our reports. If we can strip out the riskmetric layout "things", it may become really efficient too.