pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
101 stars 28 forks source link

Add Package Dependencies to Reports, Part I #734

Closed Robert-Krajcik closed 8 months ago

Robert-Krajcik commented 9 months ago

This is a cleaner implementation of #723, which was left in DRAFT mode Closes both #651 and #721

codecov[bot] commented 9 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d902f3c) 77.19% compared to head (87c0ba4) 79.33%.

Files Patch % Lines
R/mod_packageDependencies.R 0.00% 9 Missing :warning:
R/mod_uploadPackage.R 0.00% 2 Missing :warning:
R/mod_downloadHandler.R 92.85% 1 Missing :warning:
R/mod_reportPreview.R 97.22% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #734 +/- ## ========================================== + Coverage 77.19% 79.33% +2.13% ========================================== Files 33 33 Lines 4964 5018 +54 ========================================== + Hits 3832 3981 +149 + Misses 1132 1037 -95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Robert-Krajcik commented 9 months ago

"suggests" will be added in Part II

Jeff-Thompson12 commented 9 months ago

@Robert-Krajcik remind me, what is the suggested way to setup TinyTeX to get the PDF downloads to work?

Robert-Krajcik commented 9 months ago

@Robert-Krajcik remind me, what is the suggested way to setup TinyTeX to get the PDF downloads to work?

As mentioned in #699 One way we can "standardize" the installation of tinytex is to have everyone just download https://yihui.org/tinytex/TinyTeX.zip (this is the moderately large zip file 225+ Mb that has everything we need) and then unzip to your AppData\Roaming folder in windows.

It would have been ideal for the bundle install to work tinytex::install_tinytex(bundle = 'TinyTeX')