search

pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
101 stars 28 forks source link

fix warning message package dependencies tab #749

Closed Robert-Krajcik closed 6 months ago

Robert-Krajcik commented 8 months ago

Adresses #748

I'm guessing this is a riskmetric error but for some packages (like dplyr below) no download information is available. This produces
Warning in format(as.numeric(comm_d1[["value"]]), big.mark = ",") : NAs introduced by coercion image

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.22%. Comparing base (b1a618d) to head (21ed813). Report is 1 commits behind head on dev.

:exclamation: Current head 21ed813 differs from pull request most recent head aa81bfc. Consider uploading reports for the commit aa81bfc to get more accurate results

Files Patch % Lines
R/utils_build_cards.R 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #749 +/- ## ========================================== - Coverage 79.34% 79.22% -0.12% ========================================== Files 33 33 Lines 5063 5029 -34 ========================================== - Hits 4017 3984 -33 + Misses 1046 1045 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jeff-Thompson12 commented 8 months ago

Okay, I'm trying to get my head around this. We clearly have download information because all the other cards are populated. It seems like something must be going wrong upstream with the cran_logs when the package is upload. @Robert-Krajcik what does the time graph look like for you? Is that still being produced with this dataset?

Edited: The missing data was pulled in from riskmetric not cran_logs. Don't know what caused it to happen for just that metric.

AARON-CLARK commented 7 months ago

per discussion on 2/27, should we actually hide this warning? @AARON-CLARK to review.

AARON-CLARK commented 6 months ago

Just curious, Is there a specific package that this is happening for?

In either case, after reviewing this a little more, I don't think we want to clear out a pkg_metric_error message. Especially since the app cards are already mature enough handling the error just fine (Displaying "Not Found").

I will close this PR. But if we can identify what is happening here, we should open an issue on the riskmetric repo!