Closed BarbMik closed 2 months ago
v4.2.3
@Jeff-Thompson12, Barbara did a great job preparing this branch which contains the new "About page", closing #752. I made some edits to this branch as well to address some of her concerns from earlier this week, plus I added my own touch. However, now the tests are failing and I'm not exactly sure why. Do you mind reviewing this PR and taking a peek at the tests?
Oh wow, RE: 566a918 - what a noob. Sorry, I should have figured that out.
Hi @Jeff-Thompson12, I pushed one more commit to clean up the IntroJS
txt for the new 'About' tab, so this is ready for a "final" review. Is there anything else we can do with this new tab? Is it missing anything? Does the layout make sense?
I really like the layout of the content in the new tabs. Think it looks sharp. I'm not so much of a fan of the inherited layout of the now defunct assessment criteria tab.
Picture to show the layout I'm not a fan of.
@Jeff-Thompson12, thanks for the feedback!
Old:
New:
Old:
New:
Old:
New:
- Table for "Risk Calculation" has different formatting than the other tables (e.g. Maintenance Metrics) in the "Assessment Criteria Overview"
@Jeff-Thompson12, I did everything except for this one. I go ahead and make it left justified, but I think the table was intentionally formatted differently. Maybe we can save it for a future PR?
@jthompson-arcus Logos moved into inst/app/www/images/
folder.
Closes #752
Hi, I added an 'About' tab containing the original assessment criteria tab, contacts tab, and contributors tab. The descriptions are in the R-raw folder and the new image files in the www folder. The about tab is it's own module called mod_aboutInfo.R . As this is my first PR, feedback and reviews are much appreciated! I may not have time to apply the suggested changes from the reviews, so I'm saving this as a draft.