Highlight individual contributors more than orgs on `About` tab

pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment

https://pharmar.github.io/riskassessment/

Other

101 stars 28 forks source link

Highlight individual contributors more than orgs on `About` tab #780

Closed aclark02-arcus closed 4 months ago

aclark02-arcus commented 4 months ago

Fixes #778

Here's an example of what this PR accomplishes:

I think it looks really good, but a couple of things I'm noticing right off the bat is when the person's name is too long to fit within the width of the card, it get's left justified automatically.

Also, the Past Contributors section contains cards that are noticeably taller. See below for examples. I tried toggling the height, but it didn't seem to work as expected. I also tried to make sure my images were the exact same width and height. I'm not convinced that worked either. If someone can help me figure this out, I'd be much appreciative!

Once polished, I'd like to write some testthat tests for the new functions, and I'd also like to invite current and past members to either (1) give me their permission to use their photos or (2) upload their own.

aclark02-arcus commented 4 months ago

Thanks for all the suggestions @jthompson-arcus, I was able to incorporate them all and add a few more changes. Below is what is rendered now. I basically realized that all our GitHub sources for pics were squares, so I decided to stay with the square theme throughout.

A couple of things that are still out of sorts:

looks like we lost the center-justified-items class, but this doesn't look terrible left justified
the target = "_blank" stuff still isn't working

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.27%. Comparing base (42bf8be) to head (54c54cd). Report is 95 commits behind head on dev.

:exclamation: Current head 54c54cd differs from pull request most recent head 454270f

Please upload reports for the commit 454270f to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #780 +/- ## ========================================== - Coverage 81.61% 81.27% -0.35% ========================================== Files 34 36 +2 Lines 5277 5394 +117 ========================================== + Hits 4307 4384 +77 - Misses 970 1010 +40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.