search

pharmaR / riskassessment

Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
98 stars 24 forks source link

Reverse Dep pkgs not subject to "Include Suggests" toggle #783

Open aclark02-arcus opened 1 month ago

aclark02-arcus commented 1 month ago

dplyr selected in control panel: googledrive listed as a reverse dependency of dplyr, as highlighted below. However, when I load googledrive into the db, it doesn't show up in the "Rev Deps available in db" table.

image

That's because dplyr is only a Suggest for googledrive. I don't think googledrive should show up here while the "Include Suggests" toggle is off / FALSE.

image

jthompson-arcus commented 1 month ago

I agree with you but currently the reverse dependency list is taken directly from riskmetric and is not broken down by dependency type.

jthompson-arcus commented 2 weeks ago

In order to further clarify. The reverse dependencies are being supplied to the app by riskmetric. They come as a character vector. In order for us to only show reverse dependencies where the investigated package is being imported (as opposed to merely being suggested), we would have to come up with a process to grab that information ourselves.

Alternatively, we could open a feature request on riskmetric to include this information in that metric.

aclark02-arcus commented 2 weeks ago

As discussed on 6/18 dev meetup, let's not open a request with riskmetric yet and continue to think about how to best integrate it in the future, if at all.