pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
101 stars 27 forks source link

Test coverage GHA passing despite failing to calculate #800

Closed aclark02-arcus closed 1 month ago

aclark02-arcus commented 2 months ago

Latest commit on master:

https://github.com/pharmaR/riskassessment/actions/runs/9761008268/job/26941091990#step:8:18

Originally posted by @aclark02-arcus in https://github.com/pharmaR/riskassessment/issues/656#issuecomment-2206255142

jthompson-arcus commented 2 months ago

@dgkf do you by chance know how to resolve this issue? I saw that you did some work on {covr} so I wasn't sure if you had more insight. I noticed that {riskmetric} is having the same issue. I tried a different workflow with #807 but it fails with "Not valid tokenless upload" despite (to my knowledge) passing the token.

dgkf commented 2 months ago

It looks like it's not a covr issue, but a rate limit imposed by codecov using unauthenticated uploads

[1] "Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 1598s."

And it seems that there was a change to the r-lib workflows about 2mo ago that silently ignores codecov upload failures. Our workflows were most recently updated 7mo ago so we don't have these changes, but I think this would just suppress them, not solve them.

You can either deal with the occasional rate-limiting, or add a CODECOV_TOKEN secret to the repo which will automatically be used to do authenticated uploads.

If you log in through GitHub auth at https://app.codecov.io you should see this repo in the dropdown and you can find the token in the "configure" menu next to the repo name.

jthompson-arcus commented 1 month ago

Thanks for the input. I had found the information about CODECOV_TOKEN but wasn't putting all the pieces together. Looks like we needed to both update our process and utilize the token.

aclark02-arcus commented 1 month ago

closed with #796