search

pharmaR / riskassessment

Collaborative Deployment: https://app.pharmar.org/riskassessment/ Risk Assessment Demo App: https://rinpharma.shinyapps.io/riskassessment
https://pharmar.github.io/riskassessment/
Other
101 stars 28 forks source link

Remove evaluation recording from riskmetric assessments #810

Closed jthompson-arcus closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.92%. Comparing base (ed016fc) to head (dcb0728).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #810 +/- ## ========================================== + Coverage 81.89% 81.92% +0.03% ========================================== Files 36 36 Lines 6698 6711 +13 ========================================== + Hits 5485 5498 +13 Misses 1213 1213 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jthompson-arcus commented 2 months ago

@aclark02-arcus I really don't like this solution. I went down quite the rabbit hole to get here and further to look for a better answer, but I can't find one. We can't just simply remove the .recording attribute and with_eval_recording class because the vctrs package is being used to create the pkg_metric objects. (Even if we could, that solution isn't very good either because it relies on these objects being relatively immutable). The usage of the vctrs package effectively hijacks all inner assignment type calls and forces them to conform to a particular behavior which is why each assessment has to be rebuilt using structure(). If we want a none hacky solution to this problem, I think we are going to have to get it solved upstream in the riskmetric repo.

aclark02-arcus commented 2 months ago

we are going to have to get it solved upstream in the riskmetric repo

Ya, let's make Eric aware. For now, I will mark this as 'ready for review' and test it out later today.