search

pharmaR / thevalidatoR

A mirror of insightsengineering/thevalidatoR for experimentation in support of the R Validation Hub repositories working group
MIT License
1 stars 2 forks source link

Initiate validation pipeline #4

Closed yannfeat closed 8 months ago

yannfeat commented 9 months ago

Hi @dgkf,

Please see https://github.com/yannfeat/thevalidatoR/actions/runs/7584133956. You will see that 2 checks don't pass, I didn't manage to resolve the issue. Could you please help me? The call to remotes::install_local in the report template fails when attempting to install the dependency.

Thanks.

dgkf commented 9 months ago

Just documenting a discussion from today's meeting. @csgillespie suggested testing on a simpler package such as drat. I agree - I think the issues we're seeing might be due to the complexity of the package. It will be good to identify a simpler package with a fast test suite which will also help to iterate more quickly (another candidate I always reach for in such cases is the praise package)

yannfeat commented 8 months ago

I tried doing as you suggested, but the checks are still not passing. I think the issues is in fact due to the validation template of the test package "buckbeak", which calls remotes::install_local: according to the log messages below, the installation is not going well. This was already the case when I tried to only download the source files of the package dependency without installing it myself. Maybe calling the Rmd file or the action changes the default library? I have stopped trying to fix this issue, as it might disappear on its own when we discard the Rmd files in favor of JSON templates. image

csgillespie commented 8 months ago

Can you point to the log for me?

yannfeat commented 8 months ago

Sure: https://github.com/yannfeat/thevalidatoR/actions/runs/7784025452/job/21223736386

yannfeat commented 8 months ago

@csgillespie no need to spend more time on it: as I said, the issue resolved itself on its own when we switched to JSON artifacts.