search

pharmaverse / admiral.test

Test SDTM data for use with admiral
Other
2 stars 1 forks source link

General Issue: make use of testthat 3e #131

Closed esimms999-gsk closed 1 year ago

esimms999-gsk commented 1 year ago

Background Information We want to make use of testthat 3rd edition, also known as testthat 3e. This is stricter testing than previous versions of testthat and may require changes to some of the tests to keep the results from being "noisy". See this article and this blog post for upgrading to testthat 3e.

Note: The admiral package was upgraded to testthat 3e for the 1Q2023 release. And the admiraltemplate package makes use of testthat 3e. This can be seen in the DESCRIPTION file with the testthat version >= 3.0.0 and Config/testthat/edition: 3.

Definition of Done We want testthat 3e to be used and any warnings or "noisy" messages in tests to be addressed.

Note: I do not seem to have access to this repo for assigning this issue or adding it to a project.

bms63 commented 1 year ago

I just realized that there are not tests for this package as it is just a data package.

esimms999-gsk commented 1 year ago

Should testthat be removed from the DESCRIPTION's Suggests: block?